Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke validations from import executor #1141

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Invoke validations from import executor #1141

wants to merge 1 commit into from

Conversation

vish-cs
Copy link
Contributor

@vish-cs vish-cs commented Dec 16, 2024

No description provided.

@vish-cs vish-cs assigned vish-cs and unassigned n-h-diaz Dec 16, 2024
@vish-cs vish-cs marked this pull request as draft December 16, 2024 08:58
@vish-cs vish-cs force-pushed the executor branch 3 times, most recently from 70e507b to bc84404 Compare December 16, 2024 14:26
@vish-cs vish-cs marked this pull request as ready for review January 2, 2025 13:51
ajaits
ajaits reviewed Jan 2, 2025
View reviewed changes
import-automation/executor/app/executor/import_executor.py
)
else:
# Run import script locally.
script_interpreter = _get_script_interpreter(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls retain this as the interpreter path changes for imports using shell scripts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is not removed..it's just refactored out into a separate function

@vish-cs vish-cs marked this pull request as draft January 9, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaits ajaits ajaits left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@vish-cs vish-cs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vish-cs @ajaits @n-h-diaz